magicui

magicui copied to clipboard

Changed

• Updated PNPM version requirement in package.json from >=9 to >=8 to support a wider range of PNPM versions, while still recommending PNPM version 9.0.4. Fixes #78

Added

• Added .gitattributes file to ensure consistent line endings across different operating systems. This should help avoid issues related to line ending differences when working on various os. Fixes #81

@BankkRoll is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

@BankkRoll does this fix the issue? I think the error is caused by this line: "packageManager": "[email protected]". Until you use this specific version of pnpm, it will cause this error. Can you confirm if it works?

Thanks, Arghya

Hey @itsarghyadas can confirm it worked on my end.. - Windows

This is only the suggested version

"packageManager": "[email protected]"

This is the required minimum versions

  "engines": {
    "node": ">=20.6.1",
    "pnpm": ">=8"
  },

So this is suggesting they use 9.04 but we will accept 8 < up

this is amaszing! Thanks so much for setting this up

any idea why the pnpm lockfile version is now 6.0?

I also noticed a lot of the package versions across the board were bumped down to older versions. Any idea why?

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
magicui	❌ Failed (Inspect)			May 27, 2024 8:04pm

Looks like rolling back the package versions caused build to fail :(

this is amaszing! Thanks so much for setting this up

any idea why the pnpm lockfile version is now 6.0?

I also noticed a lot of the package versions across the board were bumped down to older versions. Any idea why?

Hey @dillionverma i'll look some more into this tonight or tomorrow, sorry for the delay. Was out of town for holiday. I only changed the required version of pnpm, didnt downgrade any other package versions just added the new lock file as wouldn't build correctly without.. ill do some more research here tonight and try to get it fully compatible.

---

Looks like rolling back the package versions caused build to fail :(

Will also look into this as well while doing so to make sure again its fully compatible. Will ping you back here to test as once i check it out 🤛

The type error that UnistTree is not compatible with Node<Data> due to the missing type property should be fixed, UnistTree tree needs to extend UnistNode to fix type error.

---

Looks like rolling back the package versions caused build to fail :(

Cannot build myself as there is no prisma schema to generate and test build. If you can try and let me know! Will hop in discord maybe we can connect there easier!

tysm for this!!

i was trying to merge it in but the conflicts were messing me up a bit

i just ended up adding the changes directly to main!!

Tysm for surfacing this to the community and myself 🙏

https://github.com/magicuidesign/magicui/commit/37bc4adb244f18f0042ef3f3d27db23ef21900be

closing for now