magic-js
magic-js copied to clipboard
Published
20 hours ago •
magiclabs
magiclabs
add shouldReturnURI to configuration
📦 Pull Request
- When trying to implement Magic's loginWithRedirect social login, the social providers won't display redirect in an iframe
- We should return a URI optionally in this specific use case
🚨 Test instructions
- Create a demo app that integrates loginWithRedirect - [link](https://magic.link/docs/api/client-side-sdks/web#loginwithredirect)
- loginWithRedirect v1
- Ensure URI is returned on resolve
- loginWithRedirect v2
- Ensure URI is returned on resolve
- loginWithRedirect v1
⚠️ Don't forget to add a semver label!
Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:
minor: New Feature
Special Note
- intended for indiviudal use
📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via:
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
# or
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
