Cloudlog icon indicating copy to clipboard operation
Cloudlog copied to clipboard

[Version 2] Upgrade Checklist for users coming from V1

Open magicbug opened this issue 3 years ago • 8 comments

Thought I better write some notes down on what I was thinking for this as there are some functional changes.

  • I'd suggest we use the config table to store whether the user has seen the V2 Checklist
  • Need to suggest to user to take ownership of ALL Station Locations perhaps a button they can press
  • API this needs similar treatment to Locations, or revoke ALL API keys and tell them to make new ones.
  • Teach them about Logbooks and the importance and how to use them.
  • Perhaps a little reminder to update the Country files
  • In the config perhaps rename the user auth roles as you can now have standard users and admins with their own logbooks etc.

Theres probably some other bits, I'm doing Railways on the Air this weekend so times a bit thin but wanted to dump my brain!

magicbug avatar Sep 22 '22 13:09 magicbug

Changes to config.php

$config['auth_level'][3] = "Operator";
$config['auth_level'][99] = "Administrator";

magicbug avatar Sep 22 '22 13:09 magicbug

Changes to index.php

Remind users that they might want to set the ENVIRONMENT to production rather than development to hide errors and debugging data.

define('ENVIRONMENT', 'production');

magicbug avatar Sep 22 '22 13:09 magicbug

@phl0 pointed out that PHP 8.1 gives errors with Cloudlog. I think Codeigniter has been updated to fix this, but I need to test it out with an upgrade here. Is PHP 8.1 compatibility wanted for V2, or is 8.0 good enough for the time being?

AndreasK79 avatar Sep 25 '22 17:09 AndreasK79

8.1 would be nice but if we can scrape 8.0 that wouldn't be a bad thing :)

magicbug avatar Sep 26 '22 13:09 magicbug

8.0 works. That was upgraded last year. I think the latest dev-version for Codeigniter is ok with 8.1, but need to test.

AndreasK79 avatar Sep 26 '22 14:09 AndreasK79

Just had a quick test with the latest dev version of CI. It does not fix the errors being thrown. That means 8.1 compatibility will have to wait.

AndreasK79 avatar Sep 26 '22 16:09 AndreasK79

Just had a quick test with the latest dev version of CI. It does not fix the errors being thrown. That means 8.1 compatibility will have to wait.

Agreed

magicbug avatar Sep 26 '22 20:09 magicbug

Just had a quick test with the latest dev version of CI. It does not fix the errors being thrown. That means 8.1 compatibility will have to wait.

Roger that.

phl0 avatar Sep 26 '22 21:09 phl0

OK @AndreasK79 @phl0 I believe this is now done, if you chaps can have a look

magicbug avatar Oct 11 '22 14:10 magicbug

I'm stuck at welcome :)

AndreasK79 avatar Oct 11 '22 15:10 AndreasK79

Lovely colors too :) image

Seems to be the code tag. Need to look into that as well.

Much better: image

AndreasK79 avatar Oct 11 '22 15:10 AndreasK79

Fixed a typo in the view, but it didn't fix my issue. Need to dig more later.

AndreasK79 avatar Oct 11 '22 15:10 AndreasK79

Probably my shockingly bad IF statements.. it will be a lesson of "don't code when feeling terrible" I'm sure of it :p

magicbug avatar Oct 11 '22 15:10 magicbug

Poked a few more things and perhaps fixed, certainly isn't an issue with V1 to V2

magicbug avatar Oct 11 '22 16:10 magicbug

Unfortunately, still seem to be stuck. Same issue with cron prompt not being able to be cleared in welcome message, but also with addition of API keys. After clicking on "Claim APIs" button and have it change to "All API Keys Claimed," clicking on "check if migration complete" button then protests with same API message.

ofadam avatar Oct 11 '22 16:10 ofadam

Think I need more sleep, OK small chance its sorted

magicbug avatar Oct 11 '22 16:10 magicbug

That last commit solved it for me. I was having the exact same issue as @ofadam described above.

AndreasK79 avatar Oct 11 '22 16:10 AndreasK79

Perfect

magicbug avatar Oct 11 '22 16:10 magicbug

Yep, I'm good now as well! Thanks for all your incredible work in getting to V2, all!

ofadam avatar Oct 11 '22 16:10 ofadam

Yep, I'm good now as well! Thanks for all your incredible work in getting to V2, all!

I'll be very happy once its live, can get back to fixing bugs and building new features ;-)

magicbug avatar Oct 11 '22 16:10 magicbug

Right, sooo at some point I need to take the plunge and make this live once everyone thinks we are good to go

magicbug avatar Oct 11 '22 16:10 magicbug

OK @AndreasK79 @phl0 I believe this is now done, if you chaps can have a look

I just set up another V1 instance, added some log data and then switch branches to station_logbooks. What shall I say? All migrations ran smoothly and the upgrade worked out of the box. So let's go and get that V2 out :)

phl0 avatar Oct 11 '22 16:10 phl0

Sounds very promising!

AndreasK79 avatar Oct 11 '22 17:10 AndreasK79

I'll let it sit for a night, see if anything appears, then do a quick run through everything to look for issues then perhaps its release time.

magicbug avatar Oct 11 '22 20:10 magicbug