maester icon indicating copy to clipboard operation
maester copied to clipboard

Published 20 hours ago • verified publisher icon maester365

Make EIDSCA helper functions internal?

Open fflaten opened this issue 1 year ago • 1 comments

Do we need to expose Test-MtEidscaCR02 helper functions? They're unlikely to be reused outside the accompanying test. Maybe expose them through something like Test-MtEidscaControl -Id CR02 to reduce bloat in exported functions?

fflaten avatar Apr 14 '24 17:04 fflaten

This is a good suggestion. Would you like to submit a PR?

merill avatar Apr 16 '24 13:04 merill

Adding to backlog.

merill avatar Jul 13 '24 05:07 merill

This is a good suggestion. Would you like to submit a PR?

Sorry for the late response. I started looking into it but didn't have time to finish.

Still makes sense for EIDSCA since they're generated and don't accept any parameters for exclusions etc.

Ideally it'd be applied to e.g. CISA and Maester tests as well so exported commands would be core and reusable utilities, but a wrapper adds complexity for the test-commands that offers exclusion-parameters so probably not worth it.

fflaten avatar Jul 13 '24 06:07 fflaten