imdb-party icon indicating copy to clipboard operation
imdb-party copied to clipboard

Use HTTParty 0.8.2 instead of the latest version

Open britishtea opened this issue 13 years ago • 6 comments

Using the latest version of HTTParty (0.8.3) caused an error, which made imdb_party unusable (https://github.com/maddox/imdb-party/issues/11).

britishtea avatar Jun 25 '12 17:06 britishtea

:+1: Nice! Thanks :)

fernandobrito avatar Jul 10 '12 13:07 fernandobrito

can you fix this up to be synced with master, so I can get my green button back? :)

maddox avatar Jul 12 '12 15:07 maddox

Im sorry, I'm not sure what you mean.

britishtea avatar Jul 29 '12 21:07 britishtea

@britishtea from what I know from bitbucket.org, when you own a repo and you have a pull request, there's a button to merge the changes directly from the web interface. If there are conflicts in the merging, the button is gone.

When @maddox asks you to sync your pull request with master, he is probably asking you to apply your changes on top of his master, so he can get his "green button back".

Since your pull request consists of only 1 commit, I think you can just rebase your commit on top of his newest master and update your pull request.

Please correct me if I'm wrong.

fernandobrito avatar Jul 30 '12 00:07 fernandobrito

Bingo. :)

On Jul 29, 2012, at 8:41 PM, Fernando Brito [email protected] wrote:

@britishtea from what I know from bitbucket.org, when you own a repo and you have a pull request, there's a button to merge the changes directly from the web interface. If there are conflicts in the merging, the button is gone.

When @maddox asks you to sync your pull request with master, he is probably asking you to apply your changes on top of his master, so he can get his "green button back".

Since your pull request consists of only 1 commit, I think you can just rebase your commit on top of his newest master and update your pull request.

Please correct me if I'm wrong.

— Reply to this email directly or view it on GitHub.

maddox avatar Jul 30 '12 00:07 maddox

@maddox, I think I finally managed to do it right :s

britishtea avatar Aug 07 '12 13:08 britishtea