RemotePlayWhatever icon indicating copy to clipboard operation
RemotePlayWhatever copied to clipboard

Last stable update broke invite creation

Open OParczyk opened this issue 3 years ago • 6 comments

Probably related to #77 . Whenever I try to create an invite link, RPW crashes at

RemotePlayWhatever/RemotePlayWhatever/RemotePlayInviteHandler.cpp:92 GClientContext()->RemoteClientManager()->CreateRemotePlayInviteAndSession(rppInvitee, gameID.AppID()) with pure virtual method called at/in steamclient.so.

I tried to get my hands dirty and finally understand how you know how to do your updates, but I only came as far as to use your steamworks_dumper and diffing against https://github.com/SteamDatabase/SteamTracking/tree/master/Structs sort of pre-last-update (in lack of an pre-update steamclient.so) While a few definitions in some Interfaces were added and one removed, translating these changes into your OSW fork did not change the current behavior.

Do you have any resources for me on how one could get up to speed with (the parts of) this project and the related workflow? (And take a look into the issue ;))

I greatly appreciate this project and would love to be able to fix it on update myself, too.

OParczyk avatar Oct 01 '22 20:10 OParczyk

I have the same sentiment as OP. Im willing to help whereever i can.

joamjoamjoam avatar Oct 01 '22 23:10 joamjoamjoam

I also have a deck and can help figure out what is happening and try to fix it as well, together.

matheusfaustino avatar Oct 06 '22 09:10 matheusfaustino

To be clear, this Issue is not SteamDeck-specific and since I don't have one (yet), I can't even confirm for it to manifest "not working" exactly the same way. I'm on a regular desktop, Ubuntu 22.04

OParczyk avatar Oct 06 '22 11:10 OParczyk

I tried to get my hands dirty and finally understand how you know how to do your updates, but I only came as far as to use your steamworks_dumper and diffing against https://github.com/SteamDatabase/SteamTracking/tree/master/Structs sort of pre-last-update (in lack of an pre-update steamclient.so) While a few definitions in some Interfaces were added and one removed, translating these changes into your OSW fork did not change the current behavior.

Do you have any resources for me on how one could get up to speed with (the parts of) this project and the related workflow? (And take a look into the issue ;))

I greatly appreciate this project and would love to be able to fix it on update myself, too.

steamworks_dumper currently doesn't dump IClientEngine interface/factory, i do it manually whenever new interface is added. ( If you're interested how it's done i can explain the whole process later ) Latest steam client introduced new client interface that broke RPW. I'll try to update OSW and fix RPW asap.

m4dEngi avatar Oct 09 '22 19:10 m4dEngi

Thank you very much! I'm indeed very interested in the process and would greatly appreciate for you to share your insights.

OParczyk avatar Oct 09 '22 22:10 OParczyk

Would definitely give this a test run when it is up and running again

MrHomebrew avatar Oct 12 '22 13:10 MrHomebrew

@m4dEngi Any update on this? :)

extract avatar Nov 06 '22 18:11 extract

steamworks_dumper currently doesn't dump IClientEngine interface/factory, i do it manually whenever new interface is added. ( If you're interested how it's done i can explain the whole process later ) Latest steam client introduced new client interface that broke RPW. I'll try to update OSW and fix RPW asap.

Thank you very much for fixing the issue! While for whatever reason my own build doesn't do anything after confirming invite creation, the AppImage works fine.

Could you please document your process as offered? Thanks again!

OParczyk avatar Dec 06 '22 12:12 OParczyk

Could you please document your process as offered? Thanks again!

Sure. But a little bit later and it'll probably be here, since it's outside of scope of RPW project.

m4dEngi avatar Dec 06 '22 13:12 m4dEngi