abi-dumper icon indicating copy to clipboard operation
abi-dumper copied to clipboard

Unescaped left brace in regex is deprecated

Open hobbes1069 opened this issue 7 years ago • 5 comments

From the Fedora Bugzilla report:

/usr/bin/abi-dumper contains a Perl expression that will stop working in Perl 5.30 (late May 2019):

$ abi-dumper --help >/dev/null
Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.30), passed through in regex; marked by <-- HERE in m/(\w){ <-- HERE / at /usr/bin/abi-dumper line 3200.

You need to apply this fix:

--- /usr/bin/abi-dumper 2019-01-31 13:54:11.000000000 +0100
+++ abi-dumper  2019-03-05 09:39:06.432000000 +0100
@@ -3197,7 +3197,7 @@
     
     if(defined $LambdaSupport)
     { # struct {lambda()}
-        $N=~s/(\w){/$1 {/g;
+        $N=~s/(\w)\{/$1 {/g;
     }
     
     return ($Cache{"formatName"}{$_[1]}{$_[0]} = $N);

abi-dumper-1.1-6.fc30.noarch is affected.

https://bugzilla.redhat.com/show_bug.cgi?id=1685441

hobbes1069 avatar Mar 06 '19 14:03 hobbes1069

I'm also affected by this issue. Is there a reason to not apply this patch?

rhaschke avatar Aug 30 '19 11:08 rhaschke

This is fixed in #11 already.

t-b avatar Jan 23 '20 15:01 t-b

Good deal.

hobbes1069 avatar Jan 23 '20 15:01 hobbes1069

Actually, since this hasn't made it into a release maybe this should stay open. There has not been a release in some time so it may be time for one.

hobbes1069 avatar Jan 23 '20 15:01 hobbes1069

This still seems to apply to what is available in Debian (1.1) but there was a 1.2 release which hasn't made it to Debian on Nov. 30 2020. So it's been fixed in a release, in the meantime. The fix was in 29ab01c20b1e8015b8facd714313c92b91502078 (2017).

adriaandegroot avatar Mar 02 '21 23:03 adriaandegroot