Monet Fort

Results 16 comments of Monet Fort

Note that a new commit https://github.com/adobe/spectrum-css/commit/750c4f4fd3382166a2cc1812044d42106b17c3b7 resolves the issue of consistent vertical alignment of badge components. Badges will now center vertically so that badges with and without icons will align...

@jnurthen The change that I initially made to WHCM was to ensure the track and the fill have contrast. I did not override the track color for WHCM, but I...

# Summary of Changes Impacting Failures There are two failure patterns on field group which are expected given that the markup for field group has been updated to allow for...

> > Please take a look at https://github.com/adobe/spectrum-web-components/blob/main/packages/field-group/src/spectrum-config.js#L22-L33 where you should be able to update to `selector` values for the new classes names. You'll need to run `yarn` to ensure...

This is my assessment of the VRT failures. # Failure Pattern 1: Expected classic-dark-large-ltr — classic-dark-large-rtl — express-dark-large-ltr — express-dark-large-rtl — classic-dark-large-ltr — classic-dark-large-rtl — express-dark-large-ltr — express-dark-large-rtl — classic-light-large-ltr...

@pfulton following up on these VRTs to make sure I'm not holding this up. **Failure Pattern 2: Unexpected** Question: Is it safe to assume this is a false failure? **Failure...

It appears that all the failures are likely due to changed markup that adds a "spectrum-Badge-label" element to control the spacing required by the addition of the icon variant. The...

# Summary of Changes Impacting Failures The blue of the progress circle changed in dark and darkest themes. Here is a visual swatch reference (from left to right, swatches are...

@pfulton To complete this PR, may I please follow up on these issues described in my previous comment above? **Failure pattern 3: Unexpected** Question: Is it safe to assume this...

Failure Pattern 5 (WHCM) was reviewed with James Nurthen and a revision was made to match his recommendation.