ESC-POS-.NET icon indicating copy to clipboard operation
ESC-POS-.NET copied to clipboard

Published 20 hours ago • verified publisher icon lukevp

Fixing Barcode length validation updated for PDF417 and Code128

Open igorocampos opened this issue 1 year ago • 2 comments

Fixes #253

Based on below manuals, length cap was wrong for PDF417 and Code128

image

image

igorocampos avatar Jan 22 '24 23:01 igorocampos

@igorocampos I see the change to the other barcode variable length checks, but for the PDF one, is it really only necessary to change the length limit? the rest of the code already works correctly for longer strings? have you been able to test this on a printer?

lukevp avatar Jan 26 '24 03:01 lukevp

@igorocampos I see the change to the other barcode variable length checks, but for the PDF one, is it really only necessary to change the length limit? the rest of the code already works correctly for longer strings? have you been able to test this on a printer?

Unfortunately, I haven't :(

But according to the manual, there's no actual limit other than what you mentioned in #253, so in theory it should work. But yeah, it would be nice to have it actually tested in a printer.

igorocampos avatar Jan 26 '24 15:01 igorocampos