tsoa icon indicating copy to clipboard operation
tsoa copied to clipboard

OpenAPI 3.1 support

Open letmaik opened this issue 5 years ago • 17 comments

Sorting

  • I'm submitting a ...

    • [ ] bug report
    • [x] feature request
    • [ ] support request
  • I confirm that I

    • [x] used the search to make sure that a similar issue hasn't already been submit

Description

OpenAPI 3.1 is not released yet, but will be soon. It would be nice if tsoa gets 3.1 support eventually. This ticket should track any discussion and issues related to that.

letmaik avatar Sep 25 '20 13:09 letmaik

This issue should be kept indefinitely until OpenApi 3.1 is implemented. There's no reason to close it.

tajnymag avatar Nov 01 '20 09:11 tajnymag

I'll reopen it, but the spec tsoa generates is OpenAPI 3.1 compatible.

WoH avatar Nov 01 '20 12:11 WoH

@WoH Yes, that's correct, the issue might be only tied to the config typing. At least that's why I came here.

What features are you missing, @letmaik?

tajnymag avatar Nov 01 '20 12:11 tajnymag

@Tajnymag I'm not missing features, but since there are breaking changes with OpenAPI 3.1 I thought it would be worth explicitly checking that tsoa is compatible. See https://github.com/OAI/OpenAPI-Specification/releases/tag/3.1.0-rc0.

An example is nullable which has been removed, and a quick search in tsoa turned up this: https://github.com/lukeautry/tsoa/blob/c19d15d9cad1790544c4d5ace23c46bbad678548/packages/runtime/src/swagger/swagger.ts#L239-L241

letmaik avatar Nov 03 '20 08:11 letmaik

Seems like this was changed, my last info was deprecated, not removed. I should revisit this, as it seems like OpenAPI decided drop SemVer to push out this as a 3.1.

WoH avatar Nov 03 '20 09:11 WoH

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] avatar Dec 04 '20 00:12 github-actions[bot]

(commenting to keep the issue open)

tajnymag avatar Dec 04 '20 07:12 tajnymag

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] avatar Jan 06 '21 00:01 github-actions[bot]

Shush, StaleBot! 😀

tajnymag avatar Jan 06 '21 06:01 tajnymag

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] avatar Feb 09 '21 00:02 github-actions[bot]

I would also love it tsoa could generate a 3.1 version without using anything deprecated. Having proper JSON schema is great. Ideally, those JSON schema definitions could be extracted out into a separate document to be used stand-alone as well.

mitar avatar Mar 08 '21 18:03 mitar

Feel free to submit a PR :)

WoH avatar Mar 08 '21 19:03 WoH

Is there a plan/timeline/backlog for OpenAPI 3.1 support?

alexellison avatar Jun 14 '21 15:06 alexellison

Hello, just registering my interest in the 3.1 support, so Tuples can be used.

It seems even though my controllers/apis do not use GeoJson but some parts of my code does, tsoa refuses to build and GeoJson uses tuples.

Edit: incase someone else comes across this, my solution was tsoa.json

{
  "ignore": ["**/node_modules/@types/geojson/**"]
}

my/modals/Point.ts

export interface Point {
  type: 'Point';
  coordinates: number[];
}

Not ideal, but better than not having it

WORMSS avatar Jul 29 '21 08:07 WORMSS

Any news on openapi 3.1 support?

brckner avatar Nov 24 '21 11:11 brckner