Lukáš Hrázký
Lukáš Hrázký
@surfdado thanks for addressing the review, but the actual most important comment was not addressed: https://github.com/lukash/refloat/pull/32#discussion_r1897320143 We need well-structured code more than we need e.g. comments. Also, is this working...
Yes, it would not be pretty and could be considered hacky. I just wanted to bring it up, I won't go testing or doing it now, maybe sometime later, after...
Just to comment here I brought up on discord that the 10s timeout is not very user friendly and I asked if anyone really re-engages the flywheel this way. I...
Yeah I'd hold off with this one for later if that's ok, hopefully the smoothing will be sorted out in some way for 1.3...
@NicoAleman it seems your commit should be split into three commits, according to the bullet points in your commit message. Can you please do that? That way it's way easier...
Yeah, there's a lot more parameters that can be dynamically change according to speed and other values... I'd love to mess with these but I've got a ton of things...
~~Implemented in #52.~~ Sorry, wrong issue 😀
Having trouble to follow. You are mixing two things, constant/variable tiltback and speed/duty pushback alerts. It is ultimately not clear if you're requesting some change to one of the features...
It's not (without ugly hacks on the VESC Tool side) possible to make something configurable only on the desktop version and not on mobile. Realistically it's not possible to make...
Implemented in https://github.com/lukash/refloat/pull/52.