twoway-view

twoway-view copied to clipboard

Right now moveLayoutToPosition is called every time when we are not at very beginning of list/grid and not in process of restoring (!restoringLanes is true for most of cases). Method onLayoutChildren is called every time when child view asked to be relayouted (for example, ImageView assigning a picture), so if first visible item is visible partially, view forced to be scroll up/left to show it whole content.

This commit will fix issue https://github.com/lucasr/twoway-view/issues/159 and probably fix issues https://github.com/lucasr/twoway-view/issues/140 and https://github.com/lucasr/twoway-view/issues/156

do not fix to me. try to StaggeredGridLayoutManager

Any news on this? These are big issues with most of my Grid Layout implementations

Thanks for the PR! Sorry for the delay, busy weeks and all. I'll review and merge today or tomorrow.

@leeyc09 Can you please provide code sample? I've tested StaggeredGridLayoutManager with my fix against adapter loading placeholders from Internet, and it performed well.

@0legg ASAP.

@0legg Unfortunately, this PR breaks scrollToPosition() in grid layout managers. Needs further investigation.

This bug is preventing me to use this great library in more projects. Any ETA on fixing it @lucasr?

Any update about this? I am facing the same problem :(

I patched this and now it works fine, thanks @0legg

(and yes, you probably should merge it)

If I recall - with this fix, if you try and set an ItemDecorator, scroll down, and then scroll up, everything breaks. Just as an FYI for those using it.

I'm having the same problem, any updates recently on this bug ?

Same problem for SpannableGridLayoutManager and this fix does work for it. However this fix will import another crash issue... Any update guys? Thanks.

This fix works for me.

This causes a crash to occur if you rotate the screen after scrolling down partially and then attempt to scroll up again.

This fix works partialy. However. If i do scroll back... i get "NullPointerException" at private static int getLaneSpan(SpannableItemEntry entry, boolean isVertical, int position) { return (isVertical ? entry.colSpan : entry.rowSpan);

Can you people help me with this?

@leohgz I don't think it worth to do — library looks pretty much abandoned, and I have no enough free time and will to maintain my own fork.

Does this issue is also in your fork? wich is the main different? because i see u still keep some packages from this lib.

Hi,This i am facing this issue , how to fix this