clickhouse.rs icon indicating copy to clipboard operation
clickhouse.rs copied to clipboard

support rustls

Open tyrchen opened this issue 1 year ago • 3 comments

For certain environments, users have to avoid native-tls. Thus using rustls would be a good alternative.

tyrchen avatar Dec 02 '23 18:12 tyrchen

Looks great; thanks for your contribution.

I will release the next minor release with breaking changes and disable by default TLS or use rustls as a default backend for TLS.

Sadly, hyper-rustls doesn't support hyper v1 yet: https://github.com/rustls/hyper-rustls/issues/234 Thus, the next release is postponed until it will be migrated.

loyd avatar Dec 05 '23 18:12 loyd

Now that hyper-rustls has been updated to support Hyper v1, is there anything I can do to help get this merged?

cole-h avatar Jan 29 '24 17:01 cole-h

(I think) I made all the requested changes in a branch in my fork (https://github.com/cole-h/clickhouse.rs/tree/rustls); here's the commit I made on top of this PR's changes: https://github.com/cole-h/clickhouse.rs/commit/612bd42f7f7ad97472c4acb8694e0744d069373e

Feel free to apply that to this PR; I'd also be happy to open a PR from my branch that includes and replaces this PR, just let me know!

cole-h avatar Jan 31 '24 18:01 cole-h

Hey, any chance to merge this? Thanks.

blind-oracle avatar Jun 03 '24 12:06 blind-oracle

Now all clickhouse.rs (the master branch), hyper-tls and hyper-rustls support hyper v1, so I'm closing this PR in favor of https://github.com/loyd/clickhouse.rs/pull/102 and after rebasing that branch I'm going to release clickhouse v0.12 with it

loyd avatar Jul 15 '24 07:07 loyd