flake8-html icon indicating copy to clipboard operation
flake8-html copied to clipboard

Not compatible with flake8-5.0.0

Open sahilshah6196 opened this issue 3 years ago • 14 comments

  • flake8-html version: 0.4.2
  • Python version: 3.10
  • Operating System:

Description

New version of flake8 was released (5.0.0): https://flake8.pycqa.org/en/latest/release-notes/5.0.0.html flake8-html is not compatible with it and errors out with the following error:

Traceback (most recent call last):
  File "/usr/local/bin/flake8", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/site-packages/flake8/main/cli.py", line 22, in main
    app.run(argv)
  File "/usr/local/lib/python3.10/site-packages/flake8/main/application.py", line 336, in run
    self._run(argv)
  File "/usr/local/lib/python3.10/site-packages/flake8/main/application.py", line 326, in _run
    self.report()
  File "/usr/local/lib/python3.10/site-packages/flake8/main/application.py", line 321, in report
    self.formatter.stop()
  File "/usr/local/lib/python3.10/site-packages/flake8_html/plugin.py", line 245, in stop
    self.write_index()
  File "/usr/local/lib/python3.10/site-packages/flake8_html/plugin.py", line 281, in write_index
    versions=self.option_manager.generate_versions(),
AttributeError: 'OptionManager' object has no attribute 'generate_versions'

What I Did

Simply installed flake8 using a dockerfile with command:

RUN --mount=type=ssh pip install 'git+ssh://[email protected]/lordmauve/flake8-html.git' flake8 flake8-quotes flake8-unused-arguments

sahilshah6196 avatar Aug 01 '22 12:08 sahilshah6196

reproduced with python3.8, flake version 5.0.1 on ubuntu20

izabela1337 avatar Aug 01 '22 13:08 izabela1337

if the issue is not going to be solved soon, at least update the requirements in setup.py to

requirements = [
    'jinja2>=3.1.0',
    'pygments>=2.2.0',
    'flake8>=3.3.0,<5.0.0',
    'importlib-metadata;python_version<"3.8"',
]

iuiu34 avatar Aug 18 '22 08:08 iuiu34

Still not compatible with flake8 v6.0.0.

thbeu avatar Nov 24 '22 12:11 thbeu

Is there some actively maintained fork?

nkuttler avatar Nov 28 '22 18:11 nkuttler

You might try with v0.4.3.

thbeu avatar Nov 30 '22 09:11 thbeu

Thanks a lot, works for me!

nkuttler avatar Nov 30 '22 10:11 nkuttler

Can v0.4.3 be installed from pypi?

iuiu34 avatar Nov 30 '22 10:11 iuiu34

@iuiu34 worked for me

nkuttler avatar Nov 30 '22 11:11 nkuttler

last version is v0.4.2, is it not? https://pypi.org/project/flake8-html/

iuiu34 avatar Nov 30 '22 11:11 iuiu34

Oh, you're right, I downloaded and installed manually, sorry

nkuttler avatar Nov 30 '22 11:11 nkuttler

When will it be possible to get version 0.4.3 from pypi?

JCHacking avatar Dec 02 '22 12:12 JCHacking

Hi, sorry, I tagged 0.4.3 but release automation failed. If anyone can help with fixing that I can do a release. I can't fix it myself at the moment because I don't have access to my laptop.

lordmauve avatar Dec 03 '22 12:12 lordmauve

Hi, sorry, I tagged 0.4.3 but release automation failed. If anyone can help with fixing that I can do a release. I can't fix it myself at the moment because I don't have access to my laptop.

That should be fixed via #38, see the CI run here.

jktjkt avatar Dec 03 '22 23:12 jktjkt

I pulled 0.4.3 today from pypi and it works great with flake8 6.x! 🥳

skinitimski avatar Jan 30 '23 23:01 skinitimski