Jovica Aleksic comments

Results 157 comments of


                                            Jovica Aleksic

HMR for main process does not work if adding entry to webpack.additions.main.js

I find we need to add the accept part to the docs. Or maybe it's there and I didn't read property.

HMR for main process does not work if adding entry to webpack.additions.main.js

Added info about HMR usage to the docs, will be published with next release: https://github.com/electron-userland/electron-webpack/commit/5c9673e6dd5544197c6f5f41f51d89c5c06ab28e I think we clarified that HMR for main process works, even with custom config/entry. Feel...

HMR for main process does not work if adding entry to webpack.additions.main.js

Well, i don't want to be the naive "works for me" type of guy, but... I wasn't able to reproduce what you described, at all. Regardless of custom entry or...

HMR for main process does not work if adding entry to webpack.additions.main.js

Hi @cmeeren I too apologize for being somewhat rash. But we're getting closer to mutual understanding here :) So, first a note about what I looked at, and what HMR...

HMR for main process does not work if adding entry to webpack.additions.main.js

Not sure something can be done on library side, think we need how to properly do it on userland side..

HMR for main process does not work if adding entry to webpack.additions.main.js

Yes, I believe it's something we as users must do inside the `if (module.hot)` condition, and we need to figure out what it is. Basically something along the lines of...

“electron-webpack dev” doesn’t close all child processes

I once looked into this issue and I had the feeling that we're not sending the right signal - SIGINT, and that maybe we need to use SIGTERM instead. However,...

“electron-webpack dev” doesn’t close all child processes

For development on Windows I use this alias in `.bashrc`: ``` kill() { local name="${1}" if [ -z "$name" ]; then echo ">> Enter a process name and press [ENTER]...

“electron-webpack dev” doesn’t close all child processes

I can confirm what @glek said. Dropping the isWin conditionals in `ChildProcessManager` and using the simple way - `spawn(program, args, options)` and `child.kill("SIGINT")` - solves the issues and leads to...

“electron-webpack dev” doesn’t close all child processes

So the question is how relevant signal handling in development on windows is.. Right now, frequently starting and stopping dev environment eats up resources. When I start noticing my notebook...