localstack icon indicating copy to clipboard operation
localstack copied to clipboard

migrate S3 presign tests

Open steffyP opened this issue 3 years ago β€’ 2 comments

S3 presign test migration and cleanup

In this PR two remaining presigned-tests are migrated to tests/integration/s3/test_s3.py and the old tests/integration/test_s3.py is removed.

  • The test test_presign_check_signature_validation_for_port_permutation is marked with xfail now, as it still needs a fix. This fix will be resolved in a separate PR.

  • Some other tests related to presigned-post, that are flaky in the CI have been set to xfail or skip some validation.

  • removed xfail for test test_put_and_get_object_with_content_language_disposition and replaced it with a skip_snapshot_verify for now.

TODO:

  • [x] rebase with master and remove commits from s3-migration branch
  • [x] link follow-up PR with fix for test_presign_check_signature_validation_for_port_permutation

steffyP avatar Oct 21 '22 19:10 steffyP

LocalStack integration with Pro

βŸβ€„β€ˆβŸβ€„βŸβ€„3 files  Β±0β€‚β€ƒβŸβ€„β€ˆβŸβ€„βŸβ€„3 suites  Β±0   1h 22m 56s :stopwatch: +18s 1β€ˆ441 tests +1  1β€ˆ243 :heavy_check_mark:  -β€Š1  198 :zzz: +2  0 :x: Β±0  2β€ˆ039 runs  +1  1β€ˆ609 :heavy_check_mark:  -β€Š1  430 :zzz: +2  0 :x: Β±0 

Results for commit 702c8539. ± Comparison against base commit 21ca0e9d.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 21 '22 20:10 github-actions[bot]

all checks were successful with the commits from s3-migration. Rebasing now with master to ensure the tests are still working with the old provider.

steffyP avatar Oct 31 '22 17:10 steffyP