meteor-apm-server icon indicating copy to clipboard operation
meteor-apm-server copied to clipboard

Published 20 hours ago • verified publisher icon lmachens

Meteor 1.8

Open KoenLav opened this issue 7 years ago • 5 comments

Updated to Meteor 1.8

KoenLav avatar Oct 16 '18 21:10 KoenLav

Nice good job! I'll review it this weekend.

lmachens avatar Oct 17 '18 15:10 lmachens

I deployed it to production; found no errors in APM, but it seems APM-engine is producing some errors.

So might want to hold off merging.

I don't have time to look into it again the next couple of weeks though :(

Op wo 17 okt. 2018 17:50 schreef Leon Machens [email protected]:

Nice good job! I'll review it this weekend.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lmachens/meteor-apm-server/pull/42#issuecomment-430683511, or mute the thread https://github.com/notifications/unsubscribe-auth/AL3qWGYFidNDkambSFPHbr0C4xlser5Yks5ul1G2gaJpZM4XiRMe .

KoenLav avatar Oct 17 '18 15:10 KoenLav

Alright

lmachens avatar Oct 20 '18 07:10 lmachens

@KoenLav @lmachens is the merge conflict the only reason why this does not get merged? Need any help?

jankapunkt avatar Dec 23 '18 08:12 jankapunkt

@jankapunkt @KoenLav said, that there are some issues in the apm-engine. I am not sure what kind of issues.

lmachens avatar Dec 23 '18 09:12 lmachens