FastChat icon indicating copy to clipboard operation
FastChat copied to clipboard

Published 20 hours ago • verified publisher icon lm-sys

`encoding` parameter in `logging.basicConfig` breaks Python 3.8

Open icyblade opened this issue 2 years ago • 3 comments

In #303, encoding='utf-8' is passed to logging.basicConfig. This change breaks Python 3.8 because encoding parameter is not available until Python 3.9.

Reference: https://docs.python.org/3/library/logging.html#logging.basicConfig

icyblade avatar Apr 12 '23 06:04 icyblade

Could you send a fix?

merrymercy avatar Apr 12 '23 20:04 merrymercy

It is a bug

DearChuck avatar Apr 14 '23 08:04 DearChuck

Just delete encoding=xxxx works

CiaoHe avatar Apr 15 '23 05:04 CiaoHe