llvm-project icon indicating copy to clipboard operation
llvm-project copied to clipboard

Published 20 hours ago • verified publisher icon llvm

How can we emulate Herald Rules with Pull Requests

Open tstellar opened this issue 3 years ago • 9 comments

  • [x] Submit a feature request to GitHub for this #56635
  • [ ] Implement a solution using existing Pull Request functionality.

tstellar avatar Jul 20 '22 17:07 tstellar

@llvm/issue-subscribers-infrastructure

llvmbot avatar Jul 20 '22 17:07 llvmbot

One option for at least file path herald rules would be to add CODEOWNERS, with or without making them blocking over all, which automatically review-requests anyone referenced. If they weren't blocking anyone could add themselves to changes they're interested in. This doesn't solve most of the herald filters though.

keith avatar Nov 28 '22 18:11 keith

With Herald, you can subscribe to:

  • File paths.
  • Keywords in commit message.
  • Patch authors.

Is this correct? Anything else?

tstellar avatar Mar 30 '23 23:03 tstellar

For what it's worth, it looks like the Rust language team has build a nice solution with their rustbot (https://github.com/rustbot). It has many features including a feature to automatically assign reviewers (https://github.com/rust-lang/triagebot/wiki/Assignment#pr-assignment). Similarly, Nix has ofborg (https://github.com/apps/ofborg). For example, the bot adds a reviewer in https://github.com/NixOS/nixpkgs/pull/230966.

rikhuijzer avatar Jun 08 '23 07:06 rikhuijzer

Let's start with a goal of allowing subscription based on file paths. I believe that will be the easiest to implement and is likely the most generally useful.

tstellar avatar Jun 27 '23 20:06 tstellar

The CODEOWNERS files should be enough for that, wouldn't it?

joker-eph avatar Jun 27 '23 21:06 joker-eph

@joker-eph Yes, seems like it would work for that.

tstellar avatar Jun 27 '23 23:06 tstellar

While CODEOWNERS should work functionality-wise, anyone who wants to subscribe to paths would need to create a commit to subscribe to a folder or file. Is that really something we want?

Flakebi avatar Jun 28 '23 09:06 Flakebi

@Flakebi We could also create teams for common file paths, so people wouldn't necessarily need to create a commit to subscribe, but it does seem like our best option for now.

tstellar avatar Jun 28 '23 14:06 tstellar

This subscription issue has been extensively discussed on https://discourse.llvm.org/t/update-on-github-pull-requests/71540 even if not too many people have replied on that thread. I think we should have a very clear answer/documentation to address this issue.

If someone can recommend how to set up a filter for major email service providers like Gmail, that'll be really nice.

MaskRay avatar Jun 29 '23 20:06 MaskRay