go-livepeer-basicnet icon indicating copy to clipboard operation
go-livepeer-basicnet copied to clipboard

logging: Print abbreviated peer IDs.

Open j0sh opened this issue 7 years ago • 3 comments

Easier to distinguish and diagnose issues with rather than using the full hex-encoded address.

j0sh avatar Apr 27 '18 00:04 j0sh

Hmm... This is gonna make it hard to match up with the StrmIDs, since it's composed of the full hex nodeID and a random byte array.

ericxtang avatar Apr 27 '18 00:04 ericxtang

Does that come in handy? Usually I'm looking at the logs between adjacent peers, which usually don't match the stream ID (bootnodes etc). If we do need to print the actual stream ID in places, then perhaps we should do it in abbreviated form as well (eg, by extracting the broadcaster nodeid).

j0sh avatar Apr 27 '18 00:04 j0sh

🚢

ericxtang avatar Apr 27 '18 05:04 ericxtang