egress icon indicating copy to clipboard operation
egress copied to clipboard

Published 20 hours ago • verified publisher icon livekit

[FEATURE] http support for s3 compatible storage

Open riclava opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe. Yes, when deploy egress to private cloud, egress may connect to s3 compatible storage like MinIO, tls is not required

Describe the solution you'd like add "awsConfig.DisableSSL = aws.Bool(true)" to related code, change protocol of conf

Describe alternatives you've considered I just put code like below as my temporary solution, but it will cause a new problem: params of s3 from api will not support tls ;-(

secure := os.Getenv("S3_SECURE")
if secure == "false" {
  awsConfig.DisableSSL = aws.Bool(true)
}

Additional context NO

riclava avatar Apr 14 '23 07:04 riclava

Do you want to open a PR for this? I would recommend the following in newS3Uploader

  • check S3 URL to see if it's https or http
  • if http, set DisableSSL to true

davidzhao avatar May 03 '23 21:05 davidzhao

In progress

riclava avatar May 17 '23 08:05 riclava

have already added support for AliOSS in egress. Could you add support for ctyunOSS , or open an interface for uploading to cloud storage

ananix avatar May 16 '24 11:05 ananix