fastest icon indicating copy to clipboard operation
fastest copied to clipboard

Re-enable -b before command

Open liuggio opened this issue 10 years ago • 10 comments

Execute a process before consuming the queue, it executes this command once per process, useful for init schema and load fixtures.

liuggio avatar Sep 23 '15 15:09 liuggio

One way to handle this is to use phpunit.xml.dist file and define used bootstrap file there.

tarlepp avatar Sep 13 '17 15:09 tarlepp

@tarlepp do you think that this https://github.com/liuggio/fastest/issues/102 could be tackled with phpunit.xml.dist?

DonCallisto avatar Sep 23 '17 12:09 DonCallisto

(or at least, if -b is already enabled in fastest, we can close this)

DonCallisto avatar Sep 23 '17 12:09 DonCallisto

@DonCallisto currently fastest won't fail at all if phpunit.xml.dist bootstrap fails (eg. that has simple die(); on that script). And then fastest won't show any errors about any of those tests...

And this is quite annoying and really hard to actually figure out what is going on. Picture below to show this. image

See that my bootstrap.php has die(); on line 24, and then if I run ./vendor/bin/fastest -x phpunit.xml.dist it doesn't fail at all. And actually any of those tests are really run.

tarlepp avatar Sep 23 '17 12:09 tarlepp

Ok, so those seems to be two different problems:

  • Run fastest with native -b option should stop if any errors happens in before command
  • Run fastest with phpunit.xml should stop if any errors happens if bootstrap fails or stops.

In both case, this issue seems to be the same of #102; isn't it?

DonCallisto avatar Sep 23 '17 13:09 DonCallisto

@DonCallisto yeah the outcome is the same

tarlepp avatar Sep 23 '17 13:09 tarlepp

@tarlepp see https://github.com/liuggio/fastest/pull/104. Please, leave any comment in that PR. Moreover it solves only fastest -b "native" approach

DonCallisto avatar Sep 30 '17 13:09 DonCallisto

@tarlepp ping

DonCallisto avatar Oct 11 '17 10:10 DonCallisto

@DonCallisto it's good

tarlepp avatar Oct 11 '17 11:10 tarlepp

Partially resolved in https://github.com/liuggio/fastest/pull/104; still misses bootstrap.php fail handling

DonCallisto avatar Oct 12 '17 12:10 DonCallisto