dmarc-srg icon indicating copy to clipboard operation
dmarc-srg copied to clipboard

Published 20 hours ago • verified publisher icon liuch

Fix layout

Open smeinecke opened this issue 3 years ago • 3 comments

This fixes some layout problems:

  • grafik Fixes limited space in header for counters + print count in local format.
  • grafik Static size of badges to contains size, regardless if report is marked read or unread.
  • grafik Unform format of datetime regardless if localtime or utc is selected.

smeinecke avatar Oct 16 '22 19:10 smeinecke

I would merge some of the commits from your PR, but not all. For example, I don't like the commit in which you set a css rule width: 3em;. What if I set the following rule: text-transform: lowercase; or even text-transform: full-width;? Maybe it should be min-width? But I still don't like this one. There is too little space in the table to increase the width of its elements.

liuch avatar Oct 20 '22 23:10 liuch

Could you break the PR into logically separate entities? It would be easier to decide what to accept and what not.

liuch avatar Oct 20 '22 23:10 liuch

Have a look at this: https://github.com/liuch/dmarc-srg/commit/3a48021ffbd15c15de357ae37619435bfed20e88. I have changed the colors (your are almost the same in the dark theme and too bright) and prevented a button based on a link from changing color.

liuch avatar Oct 21 '22 00:10 liuch

Hi @liuch Can we close this old one ? Is the changes to the formatting already merged ?

williamdes avatar Jul 13 '23 08:07 williamdes