fzfx.nvim icon indicating copy to clipboard operation
fzfx.nvim copied to clipboard

Expose command and search history, marks, etc.

Open savchenko opened this issue 1 year ago • 7 comments

Meta-issue about implementing commands from the original fzf.vim.

Some of the most important ones:

  • [x] :marks in current and all opened files.
  • [ ] Command history (Ctrl+F in :)
  • [ ] File history (:bro ol)
  • [ ] Search history
  • [ ] File types (:set ft=)

Thoughts?

savchenko avatar Dec 26 '23 12:12 savchenko

yes, I would re-write them from fzf.vim, one by one.

linrongbin16 avatar Dec 26 '23 14:12 linrongbin16

@linrongbin16 , do you want any input on the above? I'd be happy to help.

savchenko avatar Jan 14 '24 09:01 savchenko

@linrongbin16 , do you want any input on the above? I'd be happy to help.

sure, I am now trying to implement the nvim builtin buffer previewer, it's super difficult, and I am struggling with it.

Also, there's another big performance improvement that introduce async/coroutine for blocking IO processing, it will make this plugin much more smooth.

linrongbin16 avatar Jan 14 '24 09:01 linrongbin16

sure, I am now trying to implement the nvim builtin buffer previewer, it's super difficult, and I am struggling with it.

I wonder if fzf-lua can be of any help. Messaged its author regarding the licensing change (it's currently AGPLv3.0 which is rather unusual for an nVim plugin).

savchenko avatar Jan 14 '24 14:01 savchenko

emmmm, the code base is completely different, I don't think I could use it.

linrongbin16 avatar Jan 14 '24 22:01 linrongbin16

hi @savchenko , I submit #627 to add 'FzfxMarks' command, it implements the marks command.

Would you please try it and give some feedbacks?

linrongbin16 avatar Mar 04 '24 09:03 linrongbin16

Would you please try it and give some feedbacks?

v6.4.0 works great! Correct jumps between the files using alphanumerical marks.

savchenko avatar May 26 '24 03:05 savchenko

Hey @linrongbin16 , do you still plan to implement those? No pressure and no expectations, I am grateful for you releasing the plugin at all!

Just saw that you have started rsvim and wonder if there is still an interest in fzfx.

savchenko avatar Nov 03 '24 10:11 savchenko

Sorry for letting you wait for so long time.

Yes I am putting most of my time in rsvim now.

But I may still spend some time to implement these commands.

I think it won't conflict with the rsvim project (at least for now).

linrongbin16 avatar Nov 03 '24 12:11 linrongbin16

I just added the ":History:" (in fzf.vim) equivalent command "FzfxCommandHistory". Please give me any feedbacks about it.

linrongbin16 avatar Dec 11 '24 03:12 linrongbin16

And I will move this issue to #749 , there lists all the missing commands in fzf.vim and fzf-lua.

Hope we could fill the big gap with them.

linrongbin16 avatar Dec 11 '24 05:12 linrongbin16