signed-url icon indicating copy to clipboard operation
signed-url copied to clipboard

Reduce middleware dependence

Open tobytwigger opened this issue 6 years ago • 0 comments

Currently, the middleware must be run in the order

\Linkeys\UrlSigner\Middleware\AddLinkToRequest,
\Linkeys\UrlSigner\Middleware\AddLinkDataToRequest,
\Linkeys\UrlSigner\Middleware\CheckLinkUnchanged,
\Linkeys\UrlSigner\Middleware\CheckLinkValid

This could cause an issue since middleware order cannot be enforced.

Suggested Solution:

  • Resolve the link from the request in AddLinkDataToRequest, CheckLinkUnchanged, CheckLinkValid to remove dependency on AddLinkToRequest.

tobytwigger avatar Jul 11 '19 16:07 tobytwigger