self-focused icon indicating copy to clipboard operation
self-focused copied to clipboard

Published 20 hours ago • verified publisher icon linkedin

refactor(scrollTo): Refactoring window.scrollTo to document.body.scrollTop/scrollLeft to avoid focus race condition in Safari 12

Open erinsinger93 opened this issue 6 years ago • 4 comments

To fix issue #10 we want to use document.body.scrollLeft/scrollTop rather than window.scrollTo because in Safari 12 there is an issue where the scroll that happens internally from focusing clobbers window.scrollTo

erinsinger93 avatar Jan 18 '19 01:01 erinsinger93

Updated to use document.body.scrollTop and document.body.scrollLeft

erinsinger93 avatar Jan 22 '19 23:01 erinsinger93

@erinsinger93 this seems reasonable, has this been tested to work as expected in modern browsers?

stefanpenner avatar Jan 28 '19 20:01 stefanpenner

@erinsinger93 Thanks for fixing #10 @sarbbottam Are we good to merge this?

yuclinandreas avatar Feb 13 '19 01:02 yuclinandreas

@krisselden could you share your thoughts!

sarbbottam avatar Feb 13 '19 01:02 sarbbottam