LiipTestFixturesBundle

LiipTestFixturesBundle copied to clipboard

Hey,

When i try to load Fixtures, pdo throws the exception from above. I found a workaround using TransactionHelper from Doctrine, but therefore i have to edit the Doctrine EntityManager, and i don't think that this should be the way to go.

    public function setUp(): void
    {
        parent::setUp();
        $this->client = self::createClient([],[]);
        $this->databaseTool = $this->getContainer()->get(DatabaseToolCollection::class)->get();
        $this->executor = $this->databaseTool->loadFixtures($this->getFixtureClasses());
    }

using this code, i get the following stacktrace:

1. App\Tests\Controller\AppBundle\AnonymousRedirectCrawlTest::testAnonymousRedirected with data set #0 ('/', '/login') PDOException: There is no active transaction /var/www/app/vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1854 /var/www/app/vendor/doctrine/orm/lib/Doctrine/ORM/EntityManager.php:253 /var/www/app/vendor/doctrine/data-fixtures/lib/Doctrine/Common/DataFixtures/Executor/ORMExecutor.php:76 /var/www/app/vendor/liip/test-fixtures-bundle/src/Services/DatabaseTools/ORMDatabaseTool.php:130 /var/www/app/tests/Setup/AbstractCrawlTest.php:70

I'm using PHP 8.1.7, PHPUnit 8.5.27, liip/test-fixtures-bundle 2.4.0

Maybe you got a solution, on how to fix this Problem.

Ps. It's my first time, writing an Issue, so if sth. is missing, please tell me.

Jun 27 '22 09:06 SophieBoewa

Thanks for the report.

Does it work if you call the container in another way? Like this:

$this->databaseTool = static::getContainer()->get(DatabaseToolCollection::class)->get();

Jun 29 '22 15:06 alexislefebvre

Hey, sorry for the long wait.

I tried that too, the Error Message stays the same.

Jul 06 '22 12:07 SophieBoewa

I can't reproduce this issue in a Symfony 5.4 project that run tests with PHPUnit 9.5 on PHP 7.4, 8.0 and 8.1, on a MySQL database.

Could you please share a reproducer? The Symfony doc explains how to do it. Please commit the minimal code to reproduce the issue, without forgetting the composer.json and composer.lock files.

Here is my test class:

class ControllerTest extends WebTestCase
{
    protected KernelBrowser $testClient;
    protected AbstractDatabaseTool $databaseTool;

    protected function setUp(): void
    {
        parent::setUp();

        $this->testClient = static::createClient();

        self::bootKernel();

        $container = self::$kernel->getContainer();
        /** @var DatabaseToolCollection $dbToolCollection */
        $dbToolCollection = $container->get(DatabaseToolCollection::class);
        $this->databaseTool = $dbToolCollection->get();
    }

    public function testLeaderboardsNumberOfBadgesNoUser(): void
    {
        $this->databaseTool->loadFixtures([]);

        $path = '/users/leaderboards/badges/';

        $crawler = $this->testClient->request('GET', $path);

        $this->assertSame(404, $this->testClient->getResponse()->getStatusCode());
    }

    protected function tearDown(): void
    {
        parent::tearDown();
        unset($this->databaseTool);
    }
}

Jul 06 '22 18:07 alexislefebvre

I was able to reproduce this issue on a different and unrelated PR (#109):

Config Mysql (Liip\Acme\Tests\Test\ConfigMysql)
 ✘ Load fixtures and purge
   │
   │ PDOException: There is no active transaction
   │
   │ /home/runner/work/LiipTestFixturesBundle/LiipTestFixturesBundle/vendor/doctrine/dbal/src/Driver/PDO/Connection.php:123
   │ /home/runner/work/LiipTestFixturesBundle/LiipTestFixturesBundle/vendor/doctrine/dbal/src/Driver/Middleware/AbstractConnectionMiddleware.php:87
   │ /home/runner/work/LiipTestFixturesBundle/LiipTestFixturesBundle/vendor/doctrine/dbal/src/Logging/Connection.php:83
   │ /home/runner/work/LiipTestFixturesBundle/LiipTestFixturesBundle/vendor/doctrine/dbal/src/Driver/Middleware/AbstractConnectionMiddleware.php:87
   │ /home/runner/work/LiipTestFixturesBundle/LiipTestFixturesBundle/vendor/symfony/doctrine-bridge/Middleware/Debug/Connection.php:173
   │ /home/runner/work/LiipTestFixturesBundle/LiipTestFixturesBundle/vendor/doctrine/dbal/src/Connection.php:1420
   │ /home/runner/work/LiipTestFixturesBundle/LiipTestFixturesBundle/vendor/doctrine/orm/lib/Doctrine/ORM/EntityManager.php:253
   │ /home/runner/work/LiipTestFixturesBundle/LiipTestFixturesBundle/vendor/doctrine/data-fixtures/lib/Doctrine/Common/DataFixtures/Executor/ORMExecutor.php:76
   │ /home/runner/work/LiipTestFixturesBundle/LiipTestFixturesBundle/src/Services/DatabaseTools/ORMDatabaseTool.php:127
   │ /home/runner/work/LiipTestFixturesBundle/LiipTestFixturesBundle/tests/Test/ConfigMysqlTest.php:277

full log (they may be deleted in the future)

The error only appear with PHP 8.0 and 8.1, so it may be due to different versions of dependencies. But the tests are randomized so we can't be sure.

It may be related to https://github.com/doctrine/DoctrineFixturesBundle/issues/348 and/or https://github.com/doctrine/DoctrineFixturesBundle/issues/363

Jul 08 '22 13:07 alexislefebvre

Sorry i wasn't able to build a reproducer till this day, i'm trying to work on this now.

Jul 21 '22 08:07 SophieBoewa

So it looks like the creation and deletion of the dabase causes this error, I didn't found a solution yet.

Please try this workaround: https://github.com/liip/LiipTestFixturesBundle/blob/2.x/doc/caveats.md#damadoctrinetestbundle

liip_test_fixtures:
    keep_database_and_schema: true

Aug 07 '22 14:08 alexislefebvre

Have you found the solution? I'm facing the same issue.

Sep 11 '22 08:09 TymekB

Same here.

Using: PHP 8.2 mariadb 10.8.3. phpunit 9.6.3 symfony: 6.2 doctrine: 2.14 test-fixtures-bundle 2.6.0

    public function setUp(): void
    {
        parent::setUp();
        $this->client = static::createClient();
        $this->databaseTool = static::getContainer()->get(DatabaseToolCollection::class)->get();
    }

    public function testIndexAction(): void
    {
        $this->databaseTool->loadFixtures([Fixtures::class]);
        // ...

Feb 22 '23 21:02 Lorenzschaef