lnd

lnd copied to clipboard

The pr adds the ability to get a header hash of a block at a given block height from the neutrino sub-server. I would consider this a fix to #6688, this is how the bitcoin core api interface is designed (https://chainquery.com/bitcoin-cli/getblock).

@bhandras Could you please review this.

This is my first time reviewing an LND PR, but I can utACK it for now. If I get time i can test it soon(tm).

@bhandras Thanks for taking the time to review it.

@yyforyongyu If you have time; could you please review this.

@yyforyongyu Thanks for review! I can look into adding itests. In that case I would add them to all the sub-server functions as a separate PR.

@yyforyongyu Will add itests when this is merged.

@yyforyongyu The method is accessible from both CLI and REST to answer your question. Just added access to them in the different commits which is a bit confusing.

@erikek, remember to re-request review from reviewers when ready

@guggero Maybe this can make it into 0.15.1?