libtommath icon indicating copy to clipboard operation
libtommath copied to clipboard

Change version numbers before 2.0 release

Open nijtmans opened this issue 5 years ago • 5 comments

The (microsoft) convension for dll's doesn't start with "lib" as on UNIX. So I suggest to use "tommath2.dll" as dll name. Also I made the other necessary corresponding makefile-related changes for the major upgrade.

nijtmans avatar Dec 05 '19 10:12 nijtmans

The "big change" here is the name change of the dll. I am not sure if we want to include the version number in the name. This is the job of a distribution or package builder I think. @sjaeckel will take care of the other changes regarding the version numbers.

minad avatar Dec 05 '19 11:12 minad

On other platforms than Windows - indeed - it is not customary to have a version number in the library name. On Windows it's normal (examples: ws2_32.dll, zlib1.dll, winsqlite3.dll, tcl86.dll, msvcr100.dll ...). Windows dll's simply don't have a suitable mechanism as other platforms do.

nijtmans avatar Dec 05 '19 11:12 nijtmans

ping?

nijtmans avatar Mar 10 '20 14:03 nijtmans

This will only be merged right before the 2.0.0 release, so there's no need to rebase now.

sjaeckel avatar Mar 10 '20 21:03 sjaeckel

This will only be merged right before the 2.0.0 release, so there's no need to rebase now.

Ah, thanks!

czurnieden avatar Mar 10 '20 21:03 czurnieden