libsndfile icon indicating copy to clipboard operation
libsndfile copied to clipboard

Published 20 hours ago • verified publisher icon libsndfile

wavlike: Reorganize wavlike_subchunk_parse(), Check for More Error Conditions

Open arthurt opened this issue 3 years ago • 7 comments

Reorganize the loop within wavlike_subchunk_parse().

Fix the chunk-remaining space checks to actually check for enough space for the next bytes read.

Handle short-reads errors correctly.

Don't error if unknown sub-chunks are larger than the not-used buffer..

Fixes #873 .

arthurt avatar Oct 06 '22 10:10 arthurt

CI Fuzz test unexpectedly returned an error.

evpobr avatar Oct 06 '22 10:10 evpobr

CI Fuzz test unexpectedly returned an error.

No kidding

arthurt avatar Oct 06 '22 10:10 arthurt

Uggg, The fuzzing setup isn't what I would call, easily repeatable.

arthurt avatar Oct 06 '22 10:10 arthurt

Fuzzer passed, but still giving warnings...

arthurt avatar Oct 06 '22 11:10 arthurt

Yes, I checked the previous run, so there were no such warnings.

evpobr avatar Oct 07 '22 04:10 evpobr

@evpobr @arthurt I've run the fuzzer locally using the oss-fuzz reproduce tool and the crash from the CI pipelines and it doesn't reproduce for me. Might be worth just retrying the pipeline to see if it was a one-off failure or not. I'll keep poking it a bit more though.

cmeister2 avatar Oct 08 '22 11:10 cmeister2

Ok, restarted.

evpobr avatar Oct 08 '22 11:10 evpobr

It seems like this PR had some good cleanup ... which however was hard to review and conflicted with 890. I hope it will make a comeback.

kiilerix avatar Dec 13 '22 22:12 kiilerix