usbmuxd icon indicating copy to clipboard operation
usbmuxd copied to clipboard

main: Fix: --version not reported

Open httpstorm opened this issue 1 year ago • 2 comments

Follow the pattern in other libimobiledevice utils to report version.

@nikias @FunkyM @BalkanMadman @rickmark @Blefish @marcan

httpstorm avatar Apr 26 '24 15:04 httpstorm

Hmm PACKAGE_STRING should already contain the version?

nikias avatar May 05 '24 02:05 nikias

@nikias It didn't. It prints usbmuxd. For consistency with the rest of the packages, you should use the form:

	case KEY_VERSION:
		fprintf(stderr, "%s %s\n", PACKAGE_NAME, PACKAGE_VERSION);

https://github.com/libimobiledevice/ifuse/blob/814a0e38050850937debd697fcfe6eca3de1b66f/src/ifuse.c#L685

There might be a configuration issue. grep from the last release shows ./configure:PACKAGE_STRING='usbmuxd 1.1.1'. On master, configure is generated by autoconf and does not include version ./configure:PACKAGE_STRING='usbmuxd '. ifuse does have version: ./configure:PACKAGE_STRING='ifuse 1.1.5'.

For reporting issues with builds on a particular commit, PACKAGE_VERSION e.g. 2023.10.11~360619c5-r1 is more useful than 1.1.1, since it contains the commit hash.

httpstorm avatar May 05 '24 04:05 httpstorm

e9a0dce

nikias avatar Sep 14 '24 19:09 nikias