webpack-node-externals icon indicating copy to clipboard operation
webpack-node-externals copied to clipboard

use proces.env.NODE_PATH when set to get node_modules path

Open mattkime opened this issue 9 years ago • 4 comments

the following line could check to see if proces.env.NODE_PATH. currently this must be done manually by the developer. https://github.com/liady/webpack-node-externals/blob/master/index.js#L56

mattkime avatar Jul 29 '16 21:07 mattkime

@mattkime that sounds like a good idea. As I'm not very familiar with the NODE_PATH setting, can you give an example how to improve this check? (or better yet, a PR?) thanks!

liady avatar Jul 30 '16 19:07 liady

@liady i'll make a pr. wanted to make sure there wasn't a specific reason for avoiding it. thanks!

mattkime avatar Jul 30 '16 19:07 mattkime

@mattkime is this still relevant?

liady avatar Nov 09 '16 23:11 liady

It is, apologies for forgetting about this.

mattkime avatar Nov 14 '16 03:11 mattkime