curl_cffi icon indicating copy to clipboard operation
curl_cffi copied to clipboard

Published 20 hours ago • verified publisher icon lexiforest

Add more unittests for asyncio stream mode

Open perkfly opened this issue 1 year ago • 3 comments
trafficstars

It's not well covered.

perkfly avatar Dec 22 '23 07:12 perkfly

Hi @yifeikong, I would like to take this up. Could you please give me more details, need a little bit of more context?

gmottajr avatar Dec 22 '23 11:12 gmottajr

There are a number of tests for stream mode in sync version.

https://github.com/yifeikong/curl_cffi/blob/45e687b286dc0eb9402277d5f37c834cd4a75fd5/tests/unittest/test_requests.py#L430-L610

But the async tests are not matched.

https://github.com/yifeikong/curl_cffi/blob/45e687b286dc0eb9402277d5f37c834cd4a75fd5/tests/unittest/test_async_session.py#L319-L369

perkfly avatar Dec 22 '23 12:12 perkfly

Ok, sounds good! 🚀 Shall I have it assigned it to me, please? I will gladly work on it right after I have it. 🧐 I am happy to contribute to improving the test suite for this critical aspect of the project. My approach would involve thoroughly understanding the existing sync mode tests, identifying the gaps in the async mode tests, and then crafting robust and comprehensive tests to cover these areas effectively. 🔍 Thank you for considering my request. 🙏

Best regards!

gmottajr avatar Dec 23 '23 05:12 gmottajr