coc-discord-rpc icon indicating copy to clipboard operation
coc-discord-rpc copied to clipboard

Published 20 hours ago • verified publisher icon leonardssh

feat: migrated to `@xhayper/discord-rpc`

Open xhayper opened this issue 3 years ago • 5 comments

This is a successor to #63

This should fix #59 and fix #56, if it doesn't lmk.

xhayper avatar Aug 01 '22 03:08 xhayper

Confirmed to work with snap version of Discord.

xhayper avatar Aug 03 '22 23:08 xhayper

@leonardssh please review these changes.

xhayper avatar Aug 04 '22 00:08 xhayper

My only suggestion is to please remove the yarn.lock from this commit.

SeniorMars avatar Aug 04 '22 14:08 SeniorMars

@KarlWithK we actually need yarn.lock file to be able to cache the yarn install step on CI/CD workflows.

leonardssh avatar Aug 04 '22 15:08 leonardssh

Ah I didn't know that! That sounds cool!

SeniorMars avatar Aug 04 '22 15:08 SeniorMars

Are there blockers from this pr being merged?

SeniorMars avatar Sep 29 '22 07:09 SeniorMars