go-conventionalcommits icon indicating copy to clipboard operation
go-conventionalcommits copied to clipboard

Introduce a little tool to replace the Ragel debugging lines

Open leodido opened this issue 3 years ago • 1 comments

I wrote a little Go program to strip out the Ragel debugging lines (ie., //line ...) from the resulting Go parser.

Thus, the makefile now uses such a tool rather than sed (so we don't have to care for gnu-sed vs OS X's sed etc.)


Another option would have been to use the Ragel's -L flag. But I prefer to have those debugging lines (they help when debugging huge parsers).

leodido avatar Aug 02 '22 01:08 leodido

On a side note, Go 1.14 and Go 1.15 tests break because of os.{Read,Write}File APIs.

2 options here:

  • switch to older Go APIs
  • get rid of Go 1.14 and Go 1.15

Wanna hear from y'all before going down one road or the other.

leodido avatar Aug 02 '22 01:08 leodido

Reviewpad Report

:bangbang: Errors

  • Unconventional commit detected: 'new(tools/removecomments): create little tool to strip the ragel debugging comments

Signed-off-by: Leonardo Di Donato [email protected]' (6842aba428bae949825bd67b28b9b1b04dbbab5e)

  • Unconventional commit detected: 'deps: update go modules

Signed-off-by: Leonardo Di Donato [email protected]' (0968812a781ded9ef56640da7a2a54b4b73c8d47)

:warning: Warnings

  • Please link an issue to the pull request

reviewpad[bot] avatar Feb 26 '23 17:02 reviewpad[bot]