go-conventionalcommits icon indicating copy to clipboard operation
go-conventionalcommits copied to clipboard

Published 20 hours ago • verified publisher icon leodido

upgrade: go v1.18

Open marcelosousa opened this issue 3 years ago • 2 comments

There were some issues with the build process with:

go version go1.18 darwin/amd64

Ragel State Machine Compiler version 6.10 March 2017

macOS Monterey (12.4)

This pull request updates to go1.18 and makes small nudges to the makefile to be compatible with mac os.

marcelosousa avatar Jul 11 '22 11:07 marcelosousa

@marcelosousa please take a look at https://github.com/leodido/go-conventionalcommits/pull/19 and let me know (in that PR) what do you think bout it :)

My plan would be to merge that one (but first wanna hear your feedback) and then rebase this PR on top of the updated main branch.

leodido avatar Aug 02 '22 01:08 leodido

@leodido thanks for the comment! I will take a look at #19 over the weekend and try to give you some feedback :)

marcelosousa avatar Aug 30 '22 21:08 marcelosousa

Hello @marcelosousa I decided to merge #19

leodido avatar Sep 17 '22 15:09 leodido

Makes sense!

marcelosousa avatar Sep 17 '22 15:09 marcelosousa

I ported 2 of your commits to https://github.com/leodido/go-conventionalcommits/pull/22 that I'm going to merge now :)

Thank you so much 🙇

Closing this in favor of #22

leodido avatar Sep 17 '22 15:09 leodido