pglast icon indicating copy to clipboard operation
pglast copied to clipboard

Add typehinting via py.typed

Open piercefreeman opened this issue 7 months ago • 3 comments

I'm using pglast in some downstream projects and native typehinting support in my IDE would be pretty convenient. Happy to put up a PR for this functionality but wanted to check in on appetite before I do @lelit.

piercefreeman avatar Sep 04 '25 18:09 piercefreeman

Hi, I"m taking a short break... Yes, I will appily merge your PR, especially if it comes with basic tests 😉

Bye, lele.

Message ID: @.***>

lelit avatar Sep 05 '25 03:09 lelit

+1, type hint will be very helpful

DeoLeung avatar Dec 16 '25 04:12 DeoLeung

I'm sorry, I will try to revive the work done by Pierce.

lelit avatar Dec 16 '25 06:12 lelit

Hi, working on the merge, I see the Union[str, slice] syntax: what does that mean?

My Emacs setup signals as wrong the stmts: Tuple[str, ...] = split("foo;bar") in the test...

lelit avatar Dec 20 '25 07:12 lelit

Sorry, ignore my last message above, not enough caffeine I guess ;-)

I merged @piercefreeman 's PR #178 and added some more refining commits on top.

I know it's tempting to spend inconsiderable time improving type hints, but I will consider improving them on the forthcoming v8 branch, where I will drop support for Python 3.9.

lelit avatar Dec 21 '25 16:12 lelit

Sigh, other changes that I committed on top of that caused a failure on macOS that I cannot investigate, so won't be able to do a proper release for a while.

lelit avatar Dec 26 '25 11:12 lelit