mathlib icon indicating copy to clipboard operation
mathlib copied to clipboard

chore(data/set/pointwise): split file, reducing dependencies

Open kim-em opened this issue 3 years ago • 2 comments

This splits data.set.pointwise and data.finset.pointwise each into several smaller files.

This allows us to remove or defer some imports, e.g. of order.well_founded_set and of algebra.big_operators.basic.

No changes to statements of theorems, just relocating.


Open in Gitpod

kim-em avatar Oct 13 '22 12:10 kim-em

I understand moving the later instances, but why move has_smul?

To remove the dependence on algebra.module.basic and algebra.big_operators.basic.

kim-em avatar Oct 13 '22 13:10 kim-em

has_smul.smul is in algebra.group.defs

YaelDillies avatar Oct 13 '22 13:10 YaelDillies

Okay, I agree the smul instance shouldn't have been moved out. I'll reconsider, but maybe not immediately. :-)

kim-em avatar Oct 14 '22 10:10 kim-em

@YaelDillies, I've restored the material on smul to its rightful place.

kim-em avatar Oct 18 '22 21:10 kim-em

Thanks!

Given this branch is a week behind master I suggest merging master before sending it to bors.

bors d+

ocfnash avatar Oct 25 '22 09:10 ocfnash

:v: semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

bors[bot] avatar Oct 25 '22 09:10 bors[bot]

bors merge

kim-em avatar Oct 26 '22 23:10 kim-em

Pull request successfully merged into master.

Build succeeded:

bors[bot] avatar Oct 27 '22 03:10 bors[bot]