mathlib icon indicating copy to clipboard operation
mathlib copied to clipboard

feat(analysis/seminorm): Group seminorms

Open YaelDillies opened this issue 3 years ago • 1 comments

Multiplicativize the existing add_group_seminorm material.


Open in Gitpod

YaelDillies avatar Jul 21 '22 18:07 YaelDillies

Currently, we have two ways to talk about (additive group) seminorms:

  • add_group_seminorm
  • seminormed_add_comm_group.core

I want to get rid of the second way and make seminormed groups depend on seminorms (rather than the other way around, as it is today). Now, I am adding multiplicative normed groups in #15705 so I need multiplicative seminorms to make the above plan work, and multiplicativising the API isn't much more work.

You will notice that the above doesn't get us rid of normed_add_comm_group.core. This will get solved once we introduce norms, which I'm planning to do in a separate PR and which I think is desirable anyway to be able to state results such as Asplund's averaging technique.

YaelDillies avatar Aug 13 '22 14:08 YaelDillies

Build failed (retrying...):

bors[bot] avatar Aug 15 '22 09:08 bors[bot]

Build failed (retrying...):

bors[bot] avatar Aug 15 '22 12:08 bors[bot]

Canceled.

bors[bot] avatar Aug 15 '22 13:08 bors[bot]

bors d+

eric-wieser avatar Aug 15 '22 13:08 eric-wieser

:v: YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

bors[bot] avatar Aug 15 '22 13:08 bors[bot]

bors merge

YaelDillies avatar Aug 15 '22 20:08 YaelDillies

Pull request successfully merged into master.

Build succeeded:

bors[bot] avatar Aug 16 '22 06:08 bors[bot]