Larry Reid comments

Results 98 comments of


                                            Larry Reid

Floating labels don't work inside input groups (prepend/append)

Thanks for giving this a go, @shivam091 If you're struggling to get all the tests working, I have something that I think is working. The existing code didn't make this...

Floating labels don't work inside input groups (prepend/append)

I think that HTML will work. However, be sure to try it with the `prepend` and `append` options, too. This JSFiddle shows the difference between the OP's solution and yours:...

Rich text area not auto-expanding vertically

Thanks for the report. I will try to take a look at this in the near future, but I'm pretty busy at work these days. If you want to submit...

Bootstrap 4 Custom Controls

Also see #428. Currently `collection_select` and `grouped_collection_select` don't get `:prepend` and `:append` anyway, but maybe that should change.

[v4] input_group_content method needs fixing

I think the intent of PR #367 was good, but I agree with the others that matching on `/btn/` doesn't meet the intent. To get the Bootstrap 4 alpha out...

Danger via GitHub Actions Fails when Pull Request is from a Fork

I had hoped the original solution to get Danger working again didn't require the access token. I looked into this at one time, but didn't have time to investigate why...

Danger via GitHub Actions Fails when Pull Request is from a Fork

That's right. I believe Danger also checks to see what files are modified, and if not tests are modified/added, it asks that tests be added.

No need to add `disabled` class to disabled radio button.

Look at #156 before doing anything with this issue.

No need to add `disabled` class to disabled radio button.

https://getbootstrap.com/docs/4.0/components/forms/#disabled-forms confirms that for Bootstrap 4, the correct approach is to provide the `disabled="disabled"` attribute on the `input` tag. The class is no longer needed.

Ability to globally enable custom form fields

Thanks for the suggestion. A way to globally set options makes a lot of sense. I'm open to suggestions or pull requests for this. If you decide to work on...