gitx icon indicating copy to clipboard operation
gitx copied to clipboard

Published 20 hours ago • verified publisher icon laullon

Crash when opening repo (submodule)

Open josharian opened this issue 13 years ago • 10 comments

Opening a particular submodule consistently crashes gitx. (Opening other submodules fail, but without crashes. Haven't dug into it much yet.) Using the released v0.8.4 version.

Crash report at https://gist.github.com/3241672

(Updated to move long crash report to a gist.)

josharian avatar Jul 25 '12 17:07 josharian

I also get this issue, error report here:

https://gist.github.com/3181542

joehoyle avatar Jul 26 '12 11:07 joehoyle

Also seeing problem on 0.8.4 version.

Looks like the layout of submodules has changed since upgrading to Xcode 4.4 and installing updated command line tools.

Now my submodules don't have a .git directory, they have a .git file, which references a 'gitdir' instead.

Perhaps this is the source of the crash because other projects which were cloned before my Xcode upgrade, and which have .git directories in submodules, do not cause the crash.

protocool avatar Aug 02 '12 22:08 protocool

@protocool yep, I see the same thing, with git version 1.7.11.2. That's gotta be it.

josharian avatar Aug 02 '12 22:08 josharian

I just built from master and it looks like problem is corrected, it just hasn't made it into the released version of GitX yet.

protocool avatar Aug 02 '12 22:08 protocool

@laullon Another reason for a new release.

mschaaf avatar Aug 03 '12 07:08 mschaaf

I'm on git version 1.7.11.3 and I'm having the same crash (with GitX v0.8.4). I updated to this fork because it started happening with the very old GitX I was using but it seems to be also happening on this fork. If it was due to a change in git itself that would explain why I'm suffering from this now and hadn't noticed it previously (I also updated git recently).

vitch avatar Aug 17 '12 14:08 vitch

Building my own version with XCode 4.4.1 also fixed the problem for me. I'm not familiar with OSX development but I checkout out this repo and then opened GitX.xcodeproj in XCode and pressed run. I found the generated executable in ~/Library/Developer/Xcode/DerivedData/GitX-[some-ref]/Build/Products/Debug and it doesn't crash when I open submodules. Adding the detail here incase someone else comes across this issue and is put off by the idea of compiling themselves.

vitch avatar Aug 23 '12 15:08 vitch

I too have this issue, Gitx crashes when opening submodules. Gitx version 0.8.4, git version 1.7.11.1, Mountain Lion 10.8.2. Crash log is here http://pastebin.com/1tZFguxN. I've tried upgrading Git to 1.8.2 but unfortunately that made no difference. Any ideas on how to use Gitx with submodules would be appreciated, workarounds welcome.

mattheworiordan avatar Mar 16 '13 12:03 mattheworiordan

I switched to https://github.com/rowanj/gitx, and highly recommend it. And yes, it handles submodules well.

josharian avatar Mar 17 '13 02:03 josharian

Thanks @josharian, that works well.

mattheworiordan avatar Apr 18 '13 09:04 mattheworiordan