quda icon indicating copy to clipboard operation
quda copied to clipboard

Use a macro to replace `__device__ __host__` for marking parallel functions

Open maddyscientist opened this issue 4 years ago • 1 comments

This is something to do post GK merge. Some possible options include

quda_parallel
quda_offload
QUDA_PARALLEL
QUDA_OFFLOAD

For aesthetic reasons I prefer lower case, but understand the reasoning for all caps to designate a preprocessor definition. Any other suggestions @mathiaswagner, @weinbe2, @hummingtree?

maddyscientist avatar Aug 23 '21 21:08 maddyscientist

We should use all caps specifically to designate the preprocessor definition. I'd be receptive to something like quda::parallel as well but I don't think we can namespace defines like that?

As for the specific wording, I'm relatively indifferent. As an external example, Kokkos uses KOKKOS_FUNCTION (and KOKKOS_LAMBDA, KOKKOS_INLINE_FUNCTION, etc), but I don't see a specific need to copy them.

weinbe2 avatar Aug 24 '21 19:08 weinbe2