redux-store-element icon indicating copy to clipboard operation
redux-store-element copied to clipboard

Update documentation

Open lastmjs opened this issue 7 years ago • 6 comments

Especially mention the use of bare specifiers

lastmjs avatar Mar 20 '18 19:03 lastmjs

Once Polymer 3 is out and the world is switching to ES Modules, switch this entire repo to ES Modules, and rewrite the documentation with those examples. Also...maybe get rid of the Polymer examples and use lit-html directly

lastmjs avatar Mar 20 '18 23:03 lastmjs

I've already switched to ES Modules, I've mentioned bare specifiers, and so now I just need to use lit-html for the examples

lastmjs avatar Mar 29 '18 06:03 lastmjs

Have you tried using lit-html with this element? Using lit-extended, I seem unable to set the root-reducer to the value of a function, i.e. no initialization happens.

ernsheong avatar Apr 06 '18 17:04 ernsheong

I haven't yet. What version of redux-store-element are you using? The latest version uses bare specifiers, so you'll need to use polyserve or Zwitterion or another server that rewrites. Besides that, I'll see if I can check it out soon and debug what's going on

lastmjs avatar Apr 06 '18 17:04 lastmjs

@ernsheong Try using the rootReducer attribute instead of the root-reducer attribute to set the rootReducer property.

lastmjs avatar Apr 07 '18 01:04 lastmjs

@lastmjs thanks for taking time to repro. I'm on latest npm release 2.0.6. Using https://github.com/PolymerLabs/lit-element to encapsulate lit-html, and using webpack to build.

Setting rootReducer attribute directly works! Possibly related to how lit currently works: https://github.com/PolymerLabs/lit-element/issues/29 (it doesn't process hypenated attributes for now)

(Sorry for hijacking your documentation issue)

ernsheong avatar Apr 07 '18 03:04 ernsheong