laravel-useful-additions icon indicating copy to clipboard operation
laravel-useful-additions copied to clipboard

Do not exclude seeders in calculateChecksum when refresh_db_fast.seed is enabled

Open V35CH opened this issue 1 year ago • 2 comments

When refresh_db_fast.seed is enabled, the seeders folder should not be excluded for checksum calculation. So when there is a change in seeders, the db should be seeded on the next test run.

See Patch File: seeder.patch

V35CH avatar Apr 10 '24 09:04 V35CH

Or I think it is better to use the method $this->shouldSeed() to determine to seed or not. See: \Illuminate\Foundation\Testing\Traits\CanConfigureMigrationCommands So we don't need the config anymore. And you can also drop $this->seed() in runMigrationsIfNecessary()

See Patch File: seeder.patch

V35CH avatar Apr 10 '24 09:04 V35CH

Hi @V35CH, thanks for contributing! Could maybe create a PR for that? I'm a bit cautious about downloading unfamiliar files onto my computer...

Sairahcaz avatar Apr 10 '24 12:04 Sairahcaz