laminas-crypt icon indicating copy to clipboard operation
laminas-crypt copied to clipboard

Dependency of `laminas/laminas-servicemanager` can be removed

Open boesing opened this issue 3 years ago • 2 comments

Feature Request

Q A
BC Break no

Summary

Hey there, I realized that this component still depends on servicemanager while it provides its own ContainerInterface implementation.

boesing avatar Jan 05 '23 22:01 boesing

This package is considered feature-complete, and is now in security-only maintenance mode, following a decision by the Technical Steering Committee. If you have a security issue, please follow our security reporting guidelines. If you wish to take on the role of maintainer, please nominate yourself

github-actions[bot] avatar Jan 05 '23 22:01 github-actions[bot]

This one?

https://github.com/laminas/laminas-crypt/blob/56ab1b195dad5456753601ff2e8e3d3fd9392d1a/src/Symmetric/PaddingPluginManager.php#L17

Yep, we can drop the dependency :+1:

Note that upgrading to psr/container:^2 is trickier, because the implementations are not final

Ocramius avatar Jan 05 '23 22:01 Ocramius

Closed via #33

gsteel avatar Jul 17 '24 16:07 gsteel