lambda_ethereum_consensus icon indicating copy to clipboard operation
lambda_ethereum_consensus copied to clipboard

Published 20 hours ago • verified publisher icon lambdaclass

Support kdf paths on Keystore

Open MegaRedHand opened this issue 1 year ago • 6 comments

Context: #1013

ERC-2335 keystores have a path field with a EIP-2333 path for deriving the secret. We should support non-empty values of that field.

MegaRedHand avatar Apr 23 '24 17:04 MegaRedHand

comment

afsanehForsat avatar Apr 24 '24 04:04 afsanehForsat

I'd like to tackle this!

artemd24 avatar May 23 '24 20:05 artemd24

Sure! Go ahead!

MegaRedHand avatar May 23 '24 20:05 MegaRedHand

Hello @MegaRedHand! I have started this issue, but it's a bit unclear for me, so I have a question about implementation. Should I make password parameter in decode_str! optional and in case of nil get "secret" from decoded_json["path"] file?

artemd24 avatar May 25 '24 11:05 artemd24

No. The path attribute is for deriving the secret key. I'm not sure how it works, but once the secret is retrieved you should be able to use secret + path to derive a secret key. There is more info in the EIP linked in the issue.

MegaRedHand avatar May 25 '24 15:05 MegaRedHand

Unassigned (more than 1 month of inactivity)

Arkenan avatar Jul 09 '24 11:07 Arkenan