cairo-vm icon indicating copy to clipboard operation
cairo-vm copied to clipboard

feat: bump cairo to 2.6.3

Open glihm opened this issue 1 year ago • 1 comments

Bump cairo to 2.6.3

Description

We're updating Scarb and Cairo lang and blockifier to support 2.6.3 in Dojo. Due to the fact that Katana supports starknet_in_rust as an execution engine, the motivation wa to bump starknet_in_rust too.

This requires some minor changes into the present repository. However, I'm not sure what can be the side effect of such change.

Also, the max size of the byte code, I took the current network limit. Is there already a constant somewhere we can reuse?

Would appreciate any feedback on that. :pray:

  • [ ] Linked to Github Issue
  • [ ] Unit tests added
  • [ ] Integration tests added.
  • [ ] This change requires new documentation.
  • [ ] Documentation has been added/updated.
  • [x] CHANGELOG has been updated.

glihm avatar Mar 19 '24 05:03 glihm

I'm attempting to run the tests locally and I would appreciate any guidance on that.

  1. The first test failing is that:
thread 'tests::cairo_1_run_from_entrypoint_tests::test_uint256_div_mod_hint' panicked at vm/src/tests/mod.rs:317:10:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Does this mean that the new cairo version have some offset changes?

  1. If if modify the make test to not fail at the first error, lot's of cairo tests are failing with this reason:
--- STDERR:              cairo1-run::bin/cairo1-run tests::test_run_print_ok::case_2 ---
thread 'tests::test_run_print_ok::case_2' panicked at /home/g2p/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cairo-lang-semantic-2.6.3/src/corelib.rs:59:28:
`prelude` is not a core submodule.
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The new Cairo version introduces the visibility and a new edition, but cairo-vm seems to have it's own Corelib. Should I update it?

Thanks for your time and any guidance would be appreciated here. :pray:

glihm avatar Mar 20 '24 16:03 glihm

Hi @glihm ! Thanks for the contribution but we already implemented here #1709

pefontana avatar Apr 24 '24 21:04 pefontana