yofi

yofi copied to clipboard

Hi,

I was testing out the app launcher and surfing through the code but found one bug related to flake. Also, I was messing with flake made me update it.

Bug

I found that I was not able to run nix run to get the app launcher working. Also, in my first attempt, I was thrown an error saying

$ notify-send: command not found

I am running NixOS 23.04 and can confirm that this works after adding the libnotify package as a dependency in the flake. I have spun up a fork of this repository and updated the flake for now.

Features

The feature updates include a .envrc file which helps to use direnv after allowing the cloned directory using direnv allow (nix-direnv). Additionally, I updated the cargo lock using cargo update which demanded me to bump up the rust tool-chain version from 1.64 to 1.65. I have these changes currently pushed in my Forked Respository. The purpose of this issue was to confirm if the changes are done valuable to be a PR. Let me know if you would like to see something different. Thanks

Could be so, I don't use flake myself so it might be out of date. But notify-send should not be a problem, its result code is not used anywhere:

https://github.com/l4l/yofi/blob/c0ca3365a702e7a2852a801ca357df5eb87d0cf9/src/main.rs#L274-L282