suncalc-py

suncalc-py copied to clipboard

Pandas NaT times cause unexpected behaviour

1

Currently if a datetime holding the NaT value (supported by [Numpy ](https://numpy.org/doc/stable/reference/generated/numpy.isnat.html) and [Pandas](https://pandas.pydata.org/docs/reference/api/pandas.NaT.html)) is passed to `get_position` it returns results for 12:12:43 UTC on Tuesday, September 21, 1677! Minimum...

GalenReich

Moon Illumination Issue

4

Here in function for Moon Illumination there should be some changes to be happen: 1) ` inc = atan(sdist * sin(phi), m['dist'] - sdist * cos(phi)),` # comma should not...

jindal12ketan

Timezone problem

3

There is a problem to convert times received from get_times() to format "%H:%M:%S %Z" in other time zones than UTC. I assume that: `sunrise = get_times(date, lat, lon)['sunrise']` saves the...

marcinpr

DataFrame argument returns wrong solar positions

2

When using DataFrame arguments in the `get_positions` functions, the resulting solar positions are shifted by one hour compared to calling the function in a loop with singular `datetime` arguments. I...

nmaslarinos

RuntimeWarning: invalid value encountered in arccos

4

This seems a little strange; presumably some calculation is ending up trying to take arccos of a number greater than 1 (or less than -1), which might indicate a more...

juliangilbey

lat-long vs long-lat && azimuth starting from South is just confusing

3

Very useful package, but 2 things that should be made clear in the docs IMO: 1. you point to [suncalc-js](https://github.com/mourner/suncalc) as a reimplementation, but the function there takes lat-long as...

hugoledoux

Vectorisation all casts to same datetime

1

Hi Kyle First of all thanks for this great package! I am having trouble to get the vectorization to work as per your example I have a pandas date frame...

MLUY

Wrong annotations are misleading

2

> date (datetime or a pandas series of datetimes): date and time to find sunlight phases of. **Datetime must be in UTC.** This comment made me use `datetime.utcnow()` incorrectly. And...

Hcreak

From email: > I've been playing around with your suncalc module and think I have > encountered a systematic error, here are the details and I've attached > my program....

kylebarron