keplergl_cli icon indicating copy to clipboard operation
keplergl_cli copied to clipboard

Fixed open_browser issue and added functionality for map and config file

Open ikespand opened this issue 5 years ago • 10 comments

  • Fixed issue-2 regarding the 'open_browser=False still opens browser '
  • added functionality to save maps at custom location
  • added functionality to use a custom json config file
  • added corresponding changes to the README.md

ikespand avatar Jul 17 '20 15:07 ikespand

Hey @kylebarron, do you plan to merge this pull request? The addition of output_map and config_file arguments make this excellent tool that you have written even more flexible!

ashirwad avatar Sep 01 '22 04:09 ashirwad

This PR is stale and has merge conflicts/needs to be updated with master. but in principle not opposed to merging

kylebarron avatar Sep 01 '22 09:09 kylebarron

Ok. Do you plan to add those two arguments in the near future? That would be really helpful!

ashirwad avatar Sep 01 '22 15:09 ashirwad

I don't have plans to work on this repo myself, but PRs are welcome. It probably wouldn't be too hard to update this PR with changes in master

kylebarron avatar Sep 01 '22 15:09 kylebarron

Hey guys. I will resolve the conflicts by today and will commit again.

ikespand avatar Sep 01 '22 15:09 ikespand

@kylebarron : Resolved and revised. If you've any feedbacks then let me know. And if you decide to merge then you might need to change date in CHANGELOG.md.

ikespand avatar Sep 01 '22 20:09 ikespand

Thanks @ikespand! Hope @kylebarron merges these changes soon. :)

ashirwad avatar Sep 01 '22 20:09 ashirwad

@ikespand, did you get a chance to work on this?

ashirwad avatar Oct 10 '22 19:10 ashirwad

Sorry @ashirwad .. Things were little chaotic here. But, will commit the suggestions within 2 weeks.

ikespand avatar Oct 10 '22 19:10 ikespand

No worries, @ikespand! Hope you are doing well. And thanks again for all your help with this. :)

ashirwad avatar Oct 10 '22 20:10 ashirwad